From 91c456f666cefcd49bf896bd1f1d0d8a2b4c8178 Mon Sep 17 00:00:00 2001 From: Gabriel Sancho Date: Thu, 26 Mar 2026 23:13:55 -0300 Subject: [PATCH] fix(frontend): remove default scheduler UI and restore dark page styles --- .../__tests__/pages/DashboardPage.test.tsx | 12 +++++++--- .../__tests__/pages/EntityDetailPage.test.tsx | 1 + .../src/__tests__/pages/LoginPage.test.tsx | 8 +++++++ .../src/__tests__/pages/LogsPage.test.tsx | 13 ++++++++++ frontend/src/pages/DashboardPage.tsx | 14 +---------- frontend/src/pages/EntityDetailPage.tsx | 1 - frontend/src/pages/LoginPage.tsx | 14 +++++------ frontend/src/pages/LogsPage.tsx | 24 +++++++++---------- 8 files changed, 51 insertions(+), 36 deletions(-) diff --git a/frontend/src/__tests__/pages/DashboardPage.test.tsx b/frontend/src/__tests__/pages/DashboardPage.test.tsx index f2a9d09..292a5b4 100644 --- a/frontend/src/__tests__/pages/DashboardPage.test.tsx +++ b/frontend/src/__tests__/pages/DashboardPage.test.tsx @@ -5,9 +5,11 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query' import DashboardPage from '@/pages/DashboardPage' import * as entitiesApi from '@/api/entitiesApi' import * as logsApi from '@/api/logsApi' +import * as tasksApi from '@/api/tasksApi' vi.mock('@/api/entitiesApi') vi.mock('@/api/logsApi') +vi.mock('@/api/tasksApi') const wrapper = ({ children }: { children: React.ReactNode }) => ( @@ -19,6 +21,7 @@ describe('DashboardPage', () => { it('should_display_app_version_when_rendered', () => { vi.mocked(entitiesApi.getEntities).mockResolvedValue([]) vi.mocked(logsApi.getLogs).mockResolvedValue([]) + vi.mocked(tasksApi.getAllTasks).mockResolvedValue([]) render(, { wrapper }) expect(screen.getByText(/version \d+\.\d+\.\d+/i)).toBeInTheDocument() }) @@ -28,6 +31,7 @@ describe('DashboardPage', () => { { id: '1', name: 'Entity A', email: 'a@a.com', jobTitle: 'Job A', personality: '', scheduleCron: '', contextWindowDays: 3, active: true, createdAt: '' }, ]) vi.mocked(logsApi.getLogs).mockResolvedValue([]) + vi.mocked(tasksApi.getAllTasks).mockResolvedValue([]) render(, { wrapper }) await waitFor(() => { expect(screen.getByText(/1 active entity|1 entidade/i)).toBeInTheDocument() @@ -39,13 +43,14 @@ describe('DashboardPage', () => { vi.mocked(logsApi.getLogs).mockResolvedValue([ { id: '1', entityId: 'e1', entityName: 'Entity A', promptSent: '', aiResponse: '', emailSubject: 'Memo', emailBody: '', status: 'SENT', errorMessage: null, dispatchedAt: '2024-01-01T10:00:00' }, ]) + vi.mocked(tasksApi.getAllTasks).mockResolvedValue([]) render(, { wrapper }) await waitFor(() => { expect(screen.getByText(/Memo/i)).toBeInTheDocument() }) }) - it('should_renderScheduledTasks_when_entitiesHaveSchedule', async () => { + it('should_ignoreEntityDefaultScheduler_when_onlyEntityScheduleExists', async () => { vi.mocked(entitiesApi.getEntities).mockResolvedValue([ { id: '1', @@ -60,13 +65,14 @@ describe('DashboardPage', () => { }, ]) vi.mocked(logsApi.getLogs).mockResolvedValue([]) + vi.mocked(tasksApi.getAllTasks).mockResolvedValue([]) render(, { wrapper }) await waitFor(() => { expect(screen.getByRole('heading', { name: /Scheduled Tasks/i })).toBeInTheDocument() - expect(screen.getByText(/Entity A default task/i)).toBeInTheDocument() - expect(screen.getByText(/0 9 \* \* 1/i)).toBeInTheDocument() + expect(screen.getByText(/No scheduled tasks configured yet./i)).toBeInTheDocument() + expect(screen.queryByText(/Entity A default task/i)).not.toBeInTheDocument() }) }) }) \ No newline at end of file diff --git a/frontend/src/__tests__/pages/EntityDetailPage.test.tsx b/frontend/src/__tests__/pages/EntityDetailPage.test.tsx index 54ba48f..7191de8 100644 --- a/frontend/src/__tests__/pages/EntityDetailPage.test.tsx +++ b/frontend/src/__tests__/pages/EntityDetailPage.test.tsx @@ -52,6 +52,7 @@ describe('EntityDetailPage', () => { expect(screen.getByText(/Entity A/i)).toBeInTheDocument() expect(screen.getByText(/Weekly Check-in/i)).toBeInTheDocument() expect(screen.getByText(/Last week/i)).toBeInTheDocument() + expect(screen.queryByText(/Default scheduler:/i)).not.toBeInTheDocument() }) }) diff --git a/frontend/src/__tests__/pages/LoginPage.test.tsx b/frontend/src/__tests__/pages/LoginPage.test.tsx index 4a6dc46..96245a1 100644 --- a/frontend/src/__tests__/pages/LoginPage.test.tsx +++ b/frontend/src/__tests__/pages/LoginPage.test.tsx @@ -20,6 +20,14 @@ describe('LoginPage', () => { expect(screen.getByLabelText(/password/i)).toBeInTheDocument() }) + it('should_renderDarkModeStyles_when_pageLoads', () => { + render(, { wrapper }) + + expect(screen.getByRole('heading', { name: /condado abaixo da média sa/i }).parentElement).toHaveClass('bg-slate-900') + expect(screen.getByLabelText(/password/i)).toHaveClass('bg-slate-800', 'border-slate-700', 'text-slate-100') + expect(screen.getByRole('button', { name: /login/i })).toHaveClass('bg-cyan-500', 'text-slate-950') + }) + it('should_callLoginApi_when_formSubmitted', async () => { vi.mocked(authApi.login).mockResolvedValue(undefined) render(, { wrapper }) diff --git a/frontend/src/__tests__/pages/LogsPage.test.tsx b/frontend/src/__tests__/pages/LogsPage.test.tsx index ae44c25..57b7d25 100644 --- a/frontend/src/__tests__/pages/LogsPage.test.tsx +++ b/frontend/src/__tests__/pages/LogsPage.test.tsx @@ -38,6 +38,19 @@ describe('LogsPage', () => { }) }) + it('should_renderDarkModeStyles_when_pageLoads', async () => { + vi.mocked(logsApi.getLogs).mockResolvedValue([mockLog]) + vi.mocked(entitiesApi.getEntities).mockResolvedValue([]) + + render(, { wrapper }) + + await waitFor(() => { + expect(screen.getByRole('heading', { name: /dispatch logs/i })).toHaveClass('text-slate-100') + expect(screen.getByRole('combobox')).toHaveClass('border-slate-700', 'bg-slate-800', 'text-slate-100') + expect(screen.getByText('Weekly Memo')).toHaveClass('text-slate-100') + }) + }) + it('should_filterLogsByEntity_when_filterSelected', async () => { vi.mocked(logsApi.getLogs).mockResolvedValue([mockLog]) vi.mocked(entitiesApi.getEntities).mockResolvedValue([ diff --git a/frontend/src/pages/DashboardPage.tsx b/frontend/src/pages/DashboardPage.tsx index bca4072..6af4cca 100644 --- a/frontend/src/pages/DashboardPage.tsx +++ b/frontend/src/pages/DashboardPage.tsx @@ -10,17 +10,7 @@ export default function DashboardPage() { const { data: entityTasks = [] } = useQuery({ queryKey: ['entity-tasks'], queryFn: getAllTasks }) const activeCount = entities.filter((e) => e.active).length - const scheduledDefaults = entities - .filter((entity) => entity.active && entity.scheduleCron) - .map((entity) => ({ - id: `default-${entity.id}`, - entityName: entity.name, - taskName: `${entity.name} default task`, - scheduleCron: entity.scheduleCron, - emailLookbackLabel: `Last ${entity.contextWindowDays} days`, - })) - - const scheduledCustomTasks = entityTasks.map((task) => ({ + const scheduledTasks = entityTasks.map((task) => ({ id: task.id, entityName: entities.find((entity) => entity.id === task.entityId)?.name ?? 'Unknown entity', taskName: task.name, @@ -28,8 +18,6 @@ export default function DashboardPage() { emailLookbackLabel: getEmailLookbackLabel(task.emailLookback), })) - const scheduledTasks = [...scheduledDefaults, ...scheduledCustomTasks] - return (
diff --git a/frontend/src/pages/EntityDetailPage.tsx b/frontend/src/pages/EntityDetailPage.tsx index cdd6d62..c1a8d2c 100644 --- a/frontend/src/pages/EntityDetailPage.tsx +++ b/frontend/src/pages/EntityDetailPage.tsx @@ -88,7 +88,6 @@ export default function EntityDetailPage() {

{entity.name}

{entity.jobTitle} - {entity.email}

-

Default scheduler: {entity.scheduleCron || 'Not configured'}

diff --git a/frontend/src/pages/LogsPage.tsx b/frontend/src/pages/LogsPage.tsx index 5395f89..1badfb6 100644 --- a/frontend/src/pages/LogsPage.tsx +++ b/frontend/src/pages/LogsPage.tsx @@ -15,11 +15,11 @@ export default function LogsPage() { return (
-

Dispatch Logs

+

Dispatch Logs

-
+
- + @@ -40,32 +40,32 @@ export default function LogsPage() { - + {logs.map((log) => ( - - + + - ))} {logs.length === 0 && ( -
Subject EntityDispatched At
{log.emailSubject}{log.entityName}{log.emailSubject}{log.entityName} {log.status} + {new Date(log.dispatchedAt).toLocaleString()}
+ No logs found.