feat(frontend): add task details edit flow
Add a task details action from the entity page and route it to a prefilled edit task page. Extend the local task API with single-task read and update helpers, and cover the new flow with frontend tests.
This commit is contained in:
76
frontend/src/__tests__/api/tasksApi.test.ts
Normal file
76
frontend/src/__tests__/api/tasksApi.test.ts
Normal file
@@ -0,0 +1,76 @@
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import {
|
||||
getTask,
|
||||
getTasksByEntity,
|
||||
updateTask,
|
||||
type EntityTaskResponse,
|
||||
} from '@/api/tasksApi'
|
||||
|
||||
const taskOne: EntityTaskResponse = {
|
||||
id: 'task-1',
|
||||
entityId: 'entity-1',
|
||||
name: 'Weekly Check-in',
|
||||
prompt: 'Summarize jokes',
|
||||
scheduleCron: '0 9 * * 1',
|
||||
emailLookback: 'last_week',
|
||||
createdAt: '2026-03-26T10:00:00Z',
|
||||
}
|
||||
|
||||
const taskTwo: EntityTaskResponse = {
|
||||
id: 'task-2',
|
||||
entityId: 'entity-2',
|
||||
name: 'Monthly Memo',
|
||||
prompt: 'Escalate sandwich policy',
|
||||
scheduleCron: '0 11 1 * *',
|
||||
emailLookback: 'last_month',
|
||||
createdAt: '2026-03-26T11:00:00Z',
|
||||
}
|
||||
|
||||
describe('tasksApi', () => {
|
||||
beforeEach(() => {
|
||||
localStorage.clear()
|
||||
vi.restoreAllMocks()
|
||||
})
|
||||
|
||||
it('should_returnTask_when_getTaskCalledWithExistingId', async () => {
|
||||
localStorage.setItem('condado:entity-tasks', JSON.stringify([taskOne, taskTwo]))
|
||||
|
||||
await expect(getTask('task-1')).resolves.toEqual(taskOne)
|
||||
})
|
||||
|
||||
it('should_returnTasksForEntity_when_getTasksByEntityCalled', async () => {
|
||||
localStorage.setItem('condado:entity-tasks', JSON.stringify([taskOne, taskTwo]))
|
||||
|
||||
await expect(getTasksByEntity('entity-1')).resolves.toEqual([taskOne])
|
||||
})
|
||||
|
||||
it('should_updateStoredTask_when_updateTaskCalled', async () => {
|
||||
localStorage.setItem('condado:entity-tasks', JSON.stringify([taskOne, taskTwo]))
|
||||
|
||||
const updatedTask = await updateTask('task-1', {
|
||||
entityId: 'entity-1',
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
})
|
||||
|
||||
expect(updatedTask).toEqual({
|
||||
...taskOne,
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
})
|
||||
expect(JSON.parse(localStorage.getItem('condado:entity-tasks') ?? '[]')).toEqual([
|
||||
{
|
||||
...taskOne,
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
},
|
||||
taskTwo,
|
||||
])
|
||||
})
|
||||
})
|
||||
125
frontend/src/__tests__/pages/EditTaskPage.test.tsx
Normal file
125
frontend/src/__tests__/pages/EditTaskPage.test.tsx
Normal file
@@ -0,0 +1,125 @@
|
||||
import { fireEvent, render, screen, waitFor } from '@testing-library/react'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import { MemoryRouter, Route, Routes } from 'react-router-dom'
|
||||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
|
||||
import EditTaskPage from '@/pages/EditTaskPage'
|
||||
import * as entitiesApi from '@/api/entitiesApi'
|
||||
import * as tasksApi from '@/api/tasksApi'
|
||||
|
||||
const mockNavigate = vi.fn()
|
||||
vi.mock('react-router-dom', async () => {
|
||||
const actual = await vi.importActual('react-router-dom')
|
||||
return { ...actual, useNavigate: () => mockNavigate }
|
||||
})
|
||||
|
||||
vi.mock('@/api/entitiesApi')
|
||||
vi.mock('@/api/tasksApi')
|
||||
|
||||
const wrapper = ({ children }: { children: React.ReactNode }) => (
|
||||
<QueryClientProvider client={new QueryClient({ defaultOptions: { queries: { retry: false } } })}>
|
||||
<MemoryRouter initialEntries={['/entities/entity-1/tasks/task-1']}>
|
||||
<Routes>
|
||||
<Route path="/entities/:entityId/tasks/:taskId" element={children} />
|
||||
</Routes>
|
||||
</MemoryRouter>
|
||||
</QueryClientProvider>
|
||||
)
|
||||
|
||||
const mockEntity = {
|
||||
id: 'entity-1',
|
||||
name: 'Entity A',
|
||||
email: 'a@a.com',
|
||||
jobTitle: 'Ops',
|
||||
personality: 'Formal',
|
||||
scheduleCron: '0 9 * * 1',
|
||||
contextWindowDays: 3,
|
||||
active: true,
|
||||
createdAt: '',
|
||||
}
|
||||
|
||||
const mockTask = {
|
||||
id: 'task-1',
|
||||
entityId: 'entity-1',
|
||||
name: 'Weekly Check-in',
|
||||
prompt: 'Summarize jokes',
|
||||
scheduleCron: '0 9 * * 1',
|
||||
emailLookback: 'last_week' as const,
|
||||
createdAt: '2026-03-26T10:00:00Z',
|
||||
}
|
||||
|
||||
describe('EditTaskPage', () => {
|
||||
beforeEach(() => {
|
||||
vi.mocked(entitiesApi.getEntity).mockResolvedValue(mockEntity)
|
||||
vi.mocked(tasksApi.getTask).mockResolvedValue(mockTask)
|
||||
mockNavigate.mockClear()
|
||||
})
|
||||
|
||||
it('should_renderPrefilledTaskForm_when_pageLoads', async () => {
|
||||
render(<EditTaskPage />, { wrapper })
|
||||
|
||||
await screen.findByRole('link', { name: /back to entity a/i })
|
||||
|
||||
expect(screen.getByRole('heading', { name: /edit task/i })).toBeInTheDocument()
|
||||
expect(screen.getByLabelText(/task name/i)).toHaveValue('Weekly Check-in')
|
||||
expect(screen.getByLabelText(/task prompt/i)).toHaveValue('Summarize jokes')
|
||||
expect(screen.getByLabelText(/^Email Period$/i)).toHaveValue('last_week')
|
||||
expect(screen.getByLabelText(/^Minute$/i)).toHaveValue('0')
|
||||
expect(screen.getByLabelText(/^Hour$/i)).toHaveValue('9')
|
||||
expect(screen.getByLabelText(/^Day of Month$/i)).toHaveValue('*')
|
||||
expect(screen.getByLabelText(/^Month$/i)).toHaveValue('*')
|
||||
expect(screen.getByLabelText(/^Day of Week$/i)).toHaveValue('1')
|
||||
})
|
||||
|
||||
it('should_generatePreviewAndUpdateTask_when_formSubmitted', async () => {
|
||||
vi.mocked(tasksApi.generateTaskPreview).mockResolvedValue('SUBJECT: Preview\nBODY:\nFormal nonsense')
|
||||
vi.mocked(tasksApi.updateTask).mockResolvedValue({
|
||||
...mockTask,
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
})
|
||||
|
||||
render(<EditTaskPage />, { wrapper })
|
||||
await screen.findByRole('link', { name: /back to entity a/i })
|
||||
|
||||
fireEvent.change(screen.getByLabelText(/task name/i), { target: { value: 'Daily Check-in' } })
|
||||
fireEvent.change(screen.getByLabelText(/task prompt/i), {
|
||||
target: { value: 'Ask about ceremonial coffee' },
|
||||
})
|
||||
fireEvent.change(screen.getByLabelText(/^Email Period$/i), {
|
||||
target: { value: 'last_day' },
|
||||
})
|
||||
fireEvent.click(screen.getByRole('button', { name: /Weekdays/i }))
|
||||
fireEvent.change(screen.getByLabelText(/^Hour$/i), { target: { value: '8' } })
|
||||
|
||||
fireEvent.click(screen.getByRole('button', { name: /generate test message/i }))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(tasksApi.generateTaskPreview).toHaveBeenCalled()
|
||||
expect(vi.mocked(tasksApi.generateTaskPreview).mock.calls[0][0]).toEqual(
|
||||
expect.objectContaining({
|
||||
entityId: 'entity-1',
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
})
|
||||
)
|
||||
expect(screen.getByText(/Formal nonsense/i)).toBeInTheDocument()
|
||||
})
|
||||
|
||||
fireEvent.click(screen.getByRole('button', { name: /save changes/i }))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(tasksApi.updateTask).toHaveBeenCalledWith('task-1', {
|
||||
entityId: 'entity-1',
|
||||
name: 'Daily Check-in',
|
||||
prompt: 'Ask about ceremonial coffee',
|
||||
scheduleCron: '0 8 * * 1-5',
|
||||
emailLookback: 'last_day',
|
||||
})
|
||||
expect(mockNavigate).toHaveBeenCalledWith('/entities/entity-1')
|
||||
})
|
||||
})
|
||||
})
|
||||
@@ -57,6 +57,10 @@ describe('EntityDetailPage', () => {
|
||||
'href',
|
||||
'/entities/entity-1/tasks/new'
|
||||
)
|
||||
expect(screen.getByRole('link', { name: /details/i })).toHaveAttribute(
|
||||
'href',
|
||||
'/entities/entity-1/tasks/task-1'
|
||||
)
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user